[Junie]: fix: display help output for --help argument #13446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JabRef CLI was modified to display help output when the `--help` argument is provided while JabRef is running, instead of passing the argument to the running instance. This change resolves the previous issue where users did not see the help output. Other command-line arguments remain unaffected.
koppor
reviewed
Jul 3, 2025
Member
There was a problem hiding this comment.
@jetbrains-junie
can't we use picocli here?
mixinStandardHelpOptions = true
…7-493f-8670-6157111bc3d4
Member
|
This needs more thought put into. We already do an exception for debug. Now this is going to be an abonimation. The ArgumentProcessor (PicoCli) needs to be properly used. I think handling of multiple instances has to be split and things being send to the running instance only if it is not help or sthg. Do not do a bad hotfix here. |
…7-493f-8670-6157111bc3d4
Co-authored-by: Carl Christian Snethlage <[email protected]>
…7-493f-8670-6157111bc3d4
|
@trag-bot didn't find any issues in the code! ✅✨ |
koppor
approved these changes
Jul 7, 2025
koppor
added
status: ready-for-review
Siedlerchr
deleted the
jetbrains-junie/issue-13243-run-22cefefb-9877-493f-8670-6157111bc3d4
branch
Siedlerchr
added a commit
that referenced
this pull request
Aug 2, 2025
* upstream/main: Bump com.squareup.okhttp3:okhttp from 5.0.0 to 5.1.0 in /versions (#13541) Fixed Issue 13418: "Search ShortSience" should do a latex-to-unicode conversion (#13532) New Crowdin updates (#13548) Add focus to field Link in the "Add file link" dialog. (#13520) Bump org.ow2.asm:asm from 9.6 to 9.8 in /versions (#13547) Make validation optional for saving library properties preferences (#13488) Bump org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0 in /versions (#13546) --porcelain does not output any info or warn errors on the console (#13469) Bump jablib/src/main/resources/csl-locales from `7e137db` to `3bad433` (#13545) Refine "File exists" warning (#13491) Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.8.0 to 3.11.1 (#13544) Bump org.openrewrite.rewrite from 7.8.0 to 7.11.0 (#13542) Bump jablib/src/main/resources/csl-styles from `704ff9f` to `59f124d` (#13540) Add architecture test for logging infrastructure (#13534) More harsh test on title of PR New Crowdin updates (#13533) Update extra-java-module-info plugin (#13527) [Junie]: fix: display help output for --help argument (#13446) Refactor OpenExternalFileAction (#13508)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Hey! This PR was made for you with Junie, the coding agent by JetBrains Early Access Preview
It's still learning, developing, and might make mistakes. Please make sure you review the changes before you accept them.
We’d love your feedback — join our Discord to share bugs, ideas: here.
--helpshould output help #13243--helpshould output help📊 Junie Summary
The JabRef CLI was modified to display help output when the
--helpargument is provided while JabRef is running, instead of passing the argument to the running instance. This change resolves the previous issue where users did not see the help output. Other command-line arguments remain unaffected.